Workload policy label #817
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaliby
force-pushed
the
workload-policy-label
branch
from
eeaacc9 to
9ae1d4f
Compare
scaliby
force-pushed
the
workload-policy-label
branch
from
9ae1d4f to
d28e51e
Compare
FIoannides
approved these changes
Nov 7, 2025
Collaborator
FIoannides
left a comment
FIoannides
left a comment
There was a problem hiding this comment.
LGTM, but please test this on a non-NAP cluster before merging
SikaGrr
reviewed
Nov 7, 2025
|
|
||
|
|
||
| def create_placement_policy_label(system: SystemCharacteristics) -> str: | ||
| if system.accelerator_type != AcceleratorType.TPU: |
Collaborator
There was a problem hiding this comment.
Why this guard? I'm surprised that placement_policy_label can be rendered as empty string if it's not supported, but also if accelerator is not TPU. If we need to add a label whenever placement policy is supported, then I'd expect create to return something whenever is_supported is true.
| nodeSelector: | ||
| {accelerator_label} | ||
| {machine_label} | ||
| {placement_policy_label} |
Collaborator
There was a problem hiding this comment.
It's too bad we have no test coverage for this, no unit tests cover the actual yaml content, and goldens only capture that some change happened in the template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When cluster supports placement-policy, we additionally need to append
nodeSelector.labelto workloads scheduled on this cluster.Note: this adds a new label to workloads scheduled on non-nap clusters as well. Clarifying if this is okay.
Issue
b/455642310
Testing
Tested by scheduling an actual workload.